Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opera detection is returning chrome #34

Open
merrickfox opened this issue Jan 22, 2015 · 3 comments
Open

Opera detection is returning chrome #34

merrickfox opened this issue Jan 22, 2015 · 3 comments
Assignees

Comments

@merrickfox
Copy link

Opera browsers are returning as chrome (tested in OSX, multiple opera versions, windows tested with latest opera), it looks like you are parsing the UA to find the word 'opera', which is not in the opera UA, however the word 'chrome' actually is in the user agent so it returns chrome. As far as I can tell the only unique identifier to opera is the string 'opr/26.0.1656.60' (replace the numbers with the version) and really old versions contain the string 'Presto/'

The regex that works for me is /OPR/\d{2}.\d{1}.\d{4}.\d{2}|Presto// however it would be nice if we didn't have to have a separate rule from the Detectizr stuff.

@barisaydinoglu barisaydinoglu self-assigned this Sep 28, 2015
@lepinejf
Copy link

Is this ever going to be fixed?!

@merrickfox
Copy link
Author

@lepinejf It doesn't seem like the library is maintained anymore, I recommend opening a pull request with a fix and try and breath new life into the project or just fork it like I did and apply your own fixes

@lepinejf
Copy link

@merrickfox I don't know, I've seen commits that are 2 month old. Pretty sure it's still maintained, just very slowly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants