Filter MemberEvents
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's pretty logical. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemberEvents are triggered when a user is added or removed as a collaborator, this can result in duplicate notifications such as seen here:There are two events for
Connected-Information-systems/diff-test-coverage, because GitHub returns aCreateEventfor the repository being created and aMemberEventfor the user, I think this happens when a user creates a repository in an org (created repo + added themselves as a member of the repo).I thought it might be best to just filter out the
MemberEvents as they're also not being shown on GitHub itself. Let me know what you think of this solution!