Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's unclear whether this is satire or actually serious. #2

Closed
mpldr opened this issue Mar 30, 2022 · 2 comments
Closed

It's unclear whether this is satire or actually serious. #2

mpldr opened this issue Mar 30, 2022 · 2 comments

Comments

@mpldr
Copy link

mpldr commented Mar 30, 2022

Due to:

  • Obnoxious amount of pre-commit hooks.

  • run.sh - convenient alternative to Makefile

  • Completely redundant packages (pkg without any use, pkg/myapp instead of an internal)
  • "default" Logger using 3rd party dependency
  • and more

These almost scream Enterprise FizzBuzz, but the explicit "you should not do this" is missing which in my eyes makes it almost dangerous to beginners as it promotes the use of non-standard tools, unexplained use of external dependencies, empty packages, and other things generally not considered best practice.

@mpldr
Copy link
Author

mpldr commented Mar 30, 2022

This is by no means meant as an attack (if this project is actually a serious template), but I find it is promoting ideas that can be considered outright dangerous (see also: padleft npm).

@barklan
Copy link
Owner

barklan commented Mar 31, 2022

Yes, I think I should have been more clear with this. This is not a satire and is not meant to be used as is (especially with that ridiculous amount of pre-commit hooks), but rather removing or replacing stuff that is not needed (same for unneeded dependancies). bash functions instead of Makefile were more convenient for me in very specific cases (GitLab CI jobs in containers without gnu make). I was wrong not to explain that.

This has worked for me to quickly bootstrap small services and I do not recommend this as a good for everything (even not best practice) template. Will update repo later. Thanks for your feedback!

@barklan barklan pinned this issue Mar 31, 2022
@barklan barklan closed this as completed Apr 5, 2022
@barklan barklan unpinned this issue Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants