Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast should be single line when title is empty string on Android #16

Open
recallwei opened this issue Dec 5, 2023 · 4 comments
Open
Labels
bug Something isn't working

Comments

@recallwei
Copy link

On Android:
image

On iOS:
image

Both title = ""

@baronha baronha added the bug Something isn't working label Dec 5, 2023
@baronha
Copy link
Owner

baronha commented Dec 5, 2023

OMG. I'll fix with it soon

@recallwei
Copy link
Author

Pass title = undefined is ok, I get this problem because I set a default empty string for the title (Just in my JS thinking).
It seems to be related to type conversion. In Kotlin, it is different.

Thanks for your perfect project!

@recallwei
Copy link
Author

On iOS, if I set title = undefined, It will display a default string Title, which is strange.

image

@baronha
Copy link
Owner

baronha commented Dec 5, 2023

Thank you for your quite detailed description. It's helpful in my debugging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants