Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract list of people allowed to review from MAINTAINERS #125

Open
hauleth opened this issue Jan 15, 2016 · 4 comments
Open

Extract list of people allowed to review from MAINTAINERS #125

hauleth opened this issue Jan 15, 2016 · 4 comments

Comments

@hauleth
Copy link

hauleth commented Jan 15, 2016

There is nice https://lgtm.co/ project that provide quite similar functionality but instead of configuration file it uses MAINTAINERS file inside repository. It would be nice addition to Homu.

@barosl
Copy link
Owner

barosl commented Jan 18, 2016

Interesting. Is the MAINTAINERS format widely accepted?

@hauleth
Copy link
Author

hauleth commented Jan 18, 2016

I think it is quite popular and it could be just an addition as a fallback if there is no configuration file.

@barosl
Copy link
Owner

barosl commented Jan 18, 2016

Actually, it is already possible to look up the GitHub collaborator list using the GitHub API. The reasons Homu didn't do that were:

  1. You may want to give a user the r+ permission, but not a direct access to the repository. In that case you can only add the user as a reviewer, but not as a GitHub collaborator.
  2. It consumes one additional GitHub API request, which counts against the rate limit.

Being able to modify MAINTAINERS means being able to add arbitrary reviewers. In the current approach, only GitHub collaborators can add new reviewers, so they can be thought as admins. However, the suggested method will grant that permission to any reviewers. I guess this is OK in general, but I'm curious if the previous workflow may be useful to some people.

@ashcrow
Copy link

ashcrow commented Mar 18, 2016

For the heck of it I threw together https://github.com/ashcrow/maintainers which could be helpful here.

"Python3 library for parsing MAINTAINERS files. It can parse the non toml formats listed at lgtm."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants