New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature wishlist from msharron #12
Comments
@msharron If you need to overwrite all of your pages using the |
Mkdir errors just got fixed.
I'm not sure what you mean here. I have not had this happen. Where are you seeing that error? I'm just trying to better understand it because right now I wouldn't know how to fix it. |
Wow, that sounds high tech. While I tried to keep the code as optimized as I could, I've really only tested it with about 3 pages lol |
Thanks for doing that. Nobody else has submitted any issues so that's a good thing. |
Is there a possibility to generate a whole site with all the CSS, JS and the images in place? The plugin puts out the pages nicely, but does not care for the assets. |
@MrMacStripe I like the thought, I'm just not sure of a good way to implement is such that it would work for everybody. Easier said than done, depending on how you use Grav. I suppose if people are using Grav to manage their images and don't put any of them outside of where they belong, that part could be done, however, some people store site images on a CDN or a different server altogether. As for CSS and JS, every theme has the freedom to put these anywhere, so the only effective way I could see to do this would be to scan the entire theme directory and copy the directory structure including only the CSS and JS files. What could be cool, is if the location of the assets was relocated into a new folder for the generated site, and then all pages would reflect the changes to the asset location. Additional processing could be done on the assets then, such as minifying. Speaking of minifying... I should really have the plugin minify the outputted pages. This deserves a new issue to be created, and I would like to close this one if the remaining issue doesn't stand. I will plan to close it soonish if I don't hear back. |
@msharron to my knowledge, there isn't a way to multithread in PHP. If there is, then I'm clueless. |
@msharron v0.8.0 should be the multithreaded answer you've been looking for. |
@msharron if it needs to be less intensive, let me know. I put a limit on it to 20 files at a time, but I can shrink that if it's too much. |
@msharron was the problem with generating 30,000 pages at once? What about generating them in parts? E.g. 10,000 at a time |
I have something to try first before adding any options. I noticed an option in RollingCurl to keep memory from growing too large. Adding this above the simultaneous limit should fix the problem: $rollingCurl->clearCompleted();
$rollingCurl->prunePendingRequestQueue(); |
I'm carrying this list over from #11 as that issue will be closed pending @msharron's review. Anyway, I'm currently working on these.
I think the second one there was fulfilled in v0.6.0. Correct me if I'm wrong.
The text was updated successfully, but these errors were encountered: