New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multithreading #15
Comments
I'm not sure what is exactly meant by multithreading, but I added Rolling Curl to vacuum through my pages fairly quickly a while back. I don't have any benchmarks, let's just say it feels 20x faster (dependent on how many connections you want simultaneously). Single pages complete in split seconds. |
@rymdluo thank you for this! That's precisely what is meant by multithreading. I'll plan to implement this. |
@rymdluo I'm under the impression that it's bad etiquette to store someone else's library within your project. Since Grav users should not be required to have or use Composer, though, I don't see any workaround other than to store the rolling-curl library within this repo. Also, I looked at a whole bunch of rolling-curl variations that have been done over the last several years, but in the end I found that the one you suggested was more or less the easiest and most up to date so that's the one I'll plan to use. |
@BarryMode I'm not a professional coder so I can't say about the industry. But a fork of that library mentioned that it was under the Apache license. Yes, I tried a bunch of other rolling-curls before settling on this. |
@rymdluo, if you want to push any of your code, feel free. Otherwise, I'll get to it eventually :) Sounds like you've made several modifications. |
Thanks for the invite to do so. I'll see if I can spend some time on it in the next week since the code I hold is based on a rather old fork. |
I implemented this with v0.8.0 and set a max files at one time limit to 20. Will probably add additional things to the generation text like maybe a progress bar and some other data like file size or time of success. Not much point in a progress bar, though, when the pages generate so fast. |
As was requested. I previously said I didn't know how or that I didn't think you could, but one search proved that it is possible. I'll at least look into it. I don't want to have to rely on a PHP extension for a Grav plugin though. I want it to work out of the box.
The text was updated successfully, but these errors were encountered: