Occurrence of wp_insert_post followed by is_wp_error()->throw but default is not to return WP_Error so will never throw

[markheydon]

Slightly long title but explains it pretty much. Example in Vehicle->WordPressRepository.php...

		// create
		$vehicle_id = wp_insert_post( array(
			'post_title'   => $vehicle->get_title(),
			'post_content' => $vehicle->get_description(),
			'post_excerpt' => $vehicle->get_short_description(),
			'post_author'  => $vehicle->get_author(),
			'post_type'    => PostType::VEHICLE,
			'post_status'  => $vehicle->get_status()
		) );

		if ( is_wp_error( $vehicle_id ) ) {
			throw new \Exception( 'Unable to insert post in WordPress database' );
		}

Default behaviour of wp_insert_post is NOT to return WP_Error therefore is_wp_error will always be false even on error.

Ref: https://developer.wordpress.org/reference/functions/wp_insert_post/