-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Livewire 3 & SPA Mode: "Maximum call stack size exceeded" #1567
Comments
@erikn69 because of maximebf/php-debugbar#606 ? |
Hmm not really familiar with SPA mode, but probably because the parent is resolving to itself? |
Or maybe we can just check if the parent debugbar is not the same object as the current debugbar, to prevent a loop? What is the easiest to replicate this? It seems turbolinks is deprecated for 2 years? |
Maybe, maximebf/php-debugbar#613 (comment) window.parent && window.parent != window.top && window.parent.phpdebugbar && window.parent.phpdebugbar != this I have no way to test it, @devajmeireles could you test it?? |
new version not was a fix, was a regression, maximebf/php-debugbar#613 (comment) was a possible fix, but I was hoping you could corroborate it because I can't replicate your environment |
What do you prefer? A demo repo or better instructions to test that piece of code? |
Nevermind, i did reproduce the problem |
Awesome! Anyway, here is the demo repo: https://github.com/devajmeireles/bug-debugbar
I needed to create the repo using the v1.20.0 of maximebf/php-debugbar |
Fixed on #615 |
I updated one of my projects to use Livewire 3 in SPA mode (wire:navigate) and after that, I noticed that DebugBar throws an error in the console log stating "Maximum call stack size exceeded".
... With this, the DebugBar stops to be rendered.
I confirmed that this error is related to Livewire 3's SPA mode because when I remove this, this error no longer appears.
The text was updated successfully, but these errors were encountered: