-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routes collector throwing an error #5
Comments
Version 4.0 or 4.1? And do you know which route/filters it fails on, so I can recreate? |
Ow and does |
The routes command works just fine. It's version 4.0 and it fails on every single route with all filters deactivated. I'm on Nginx 1.4.1, PHP 5.5. Had a look at the related methods and your passing the HTTP method and the current route path to Illuminate\Routing\Router::findPatternFilters() on line 88. That method only accepts 1 parameter (Request object), though, so that's the issue right there. |
Yes but that has changed a month ago; laravel/framework@9d63918#L3R1209 |
I do a composer update almost every day, so I should be on the latest version. Weird. Might be some Vagrant related issue. Let me check. |
You can do Btw, I changed the layout of the Views, hope this is better? |
Figured it out. v4.0.5 was the only installable version because of a dependency for doctrine within codeception/aspect-mock. You should set the min required Laravel version to 4.0.7 then if it throws errors with anything less or disable the routes collector automatically. Layout is much better now, thanks! |
I get this exception with the routes collector enabled:
Also, on the views collector, my view names overlap the dumped variables quite a bit on the first line (large app with some view files being 4 folders deep), making things basically unreadable. It'd be better if the dump would only start on the next line.
The text was updated successfully, but these errors were encountered: