Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes collector throwing an error #5

Closed
boris-glumpler opened this issue Sep 12, 2013 · 7 comments
Closed

Routes collector throwing an error #5

boris-glumpler opened this issue Sep 12, 2013 · 7 comments

Comments

@boris-glumpler
Copy link

I get this exception with the routes collector enabled:

Argument 1 passed to Illuminate\Routing\Router::findPatternFilters() must be an instance of Symfony\Component\HttpFoundation\Request, string given, called in /var/www/scubaclick.com/vendor/barryvdh/laravel-debugbar/src/Barryvdh/Debugbar/DataCollector/SymfonyRouteCollector.php on line 88

Also, on the views collector, my view names overlap the dumped variables quite a bit on the first line (large app with some view files being 4 folders deep), making things basically unreadable. It'd be better if the dump would only start on the next line.

@barryvdh
Copy link
Owner

Version 4.0 or 4.1? And do you know which route/filters it fails on, so I can recreate?

@barryvdh
Copy link
Owner

Ow and does php artisan routes work? Cause the Route Collector is actually based on that, it uses almost the same code.
You can disable the route collector for the time being, I'll see if I can recreate/fix tomorrow.

@boris-glumpler
Copy link
Author

The routes command works just fine. It's version 4.0 and it fails on every single route with all filters deactivated. I'm on Nginx 1.4.1, PHP 5.5.

Had a look at the related methods and your passing the HTTP method and the current route path to Illuminate\Routing\Router::findPatternFilters() on line 88. That method only accepts 1 parameter (Request object), though, so that's the issue right there.

@barryvdh
Copy link
Owner

Yes but that has changed a month ago; laravel/framework@9d63918#L3R1209
In 4.0.6 and 4.0.7, this has changed.
Are you on the latest version? Perhaps try to composer-update, do you still have this issue then?

@boris-glumpler
Copy link
Author

I do a composer update almost every day, so I should be on the latest version. Weird. Might be some Vagrant related issue. Let me check.

@barryvdh
Copy link
Owner

You can do php artisan version to see what version. Should be 4.0.7. Otherwise you might have a conflict in one of the dependencies.

Btw, I changed the layout of the Views, hope this is better?

@boris-glumpler
Copy link
Author

Figured it out. v4.0.5 was the only installable version because of a dependency for doctrine within codeception/aspect-mock. You should set the min required Laravel version to 4.0.7 then if it throws errors with anything less or disable the routes collector automatically.

Layout is much better now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants