Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 7.3 issue #543

Closed
bryce13950 opened this issue Dec 13, 2018 · 5 comments
Closed

php 7.3 issue #543

bryce13950 opened this issue Dec 13, 2018 · 5 comments

Comments

@bryce13950
Copy link

Same issue as this #503. Seems like its an issue with dompdf. Now that PHP 7.3 is in production, the underlying library should be updated.

@bryce13950
Copy link
Author

Once 0.8.3 is released then this library can be updated https://github.com/dompdf/dompdf/milestone/10

The specific issue is this one dompdf/dompdf#1822

@bryce13950
Copy link
Author

That specific issue has been fixed.

@bryce13950
Copy link
Author

dompdf has been updated, and this is now fixed.

@Rogierownage
Copy link

@bryce13950 This is not actually fixed. The latest version of barryvdh/laravel-dompdf still requires dompdf/dompdf @ v0.8 rather than 0.8.3. This error still happens as a result.

As you can see here:

"dompdf/dompdf": "^0.8"

@dmtar
Copy link

dmtar commented Jun 18, 2019

@Rogierownage You have to update your laravel-dompdf dependency with the following command:

composer update barryvdh/laravel-dompdf --with-dependencies

--with-dependencies flag will update the the dompdf/dompdf dependency to v0.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants