Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-fobi 0.10.3 downgrades django-autoslug from 1.9.3 to 1.7.1 #60

Closed
XaviP opened this issue May 12, 2017 · 8 comments
Closed

django-fobi 0.10.3 downgrades django-autoslug from 1.9.3 to 1.7.1 #60

XaviP opened this issue May 12, 2017 · 8 comments
Labels

Comments

@XaviP
Copy link

XaviP commented May 12, 2017

Hi @barseghyanartur , thanks for your work in this package.

We've made and upgrade to django-fobi 0.10.3 and we've found that when running:

pip install -r requirements.txt --upgrade

the django-autoslug is downgraded from 1.9.3 to 1.7.1, which gives an error (not in fobi):

AttributeError: 'AutoSlugField' object has no attribute 'allow_unicode'

Everything is solved upgrading again django-autoslug to 1.9.3, but any time we try to upgrade pip packages, it happens again.

We don't know exactly if it's because of django-fobi upgrade, there's other packages that has been upgraded too, but at first sight it seems so. Sorry if it's not the case, and feel free to close this issue if so.

@XaviP
Copy link
Author

XaviP commented May 12, 2017

btw, we are running django 1.10

@barseghyanartur
Copy link
Owner

@XaviP:

Thanks for reporting this. I'll check it soon.

@barseghyanartur
Copy link
Owner

@XaviP:

It seems to me that hard-coded requirement of django-autoslug==1.7.1 resides is in your own requirements.txt.

Both current branch and 0.10.3 release do install django-autoslug 1.9.3 when no Django version is detected or Django version is greater or equal to 1.9.

@XaviP
Copy link
Author

XaviP commented May 12, 2017

I've installed pipdeptree (pip install pipdeptree)
http://stackoverflow.com/a/30450999/3336408
When I run it:

(env)$ pipdeptree
[...]
django-fobi==0.11.3
  - django-autoslug [required: ==1.7.1, installed: 1.9.3]
  - django-formtools [required: >=1.0, installed: 2.0]
    - Django [required: >=1.8, installed: 1.10.7]
  - django-nine [required: >=0.1.10, installed: 0.1.12]
  - django-nonefield [required: >=0.1, installed: 0.1]
  - easy-thumbnails [required: >=2.3, installed: 2.4.1]
    - django [required: >=1.4.2, installed: 1.10.7]
    - pillow [required: Any, installed: 4.1.1]
      - olefile [required: Any, installed: 0.44]
  - Pillow [required: >=2.0.0, installed: 4.1.1]
    - olefile [required: Any, installed: 0.44]
  - requests [required: >=1.0.0, installed: 2.14.2]
  - simplejson [required: >=3.0.0, installed: 3.10.0]
  - six [required: >=1.9, installed: 1.10.0]
  - Unidecode [required: >=0.04.1, installed: 0.4.20]
  - vishap [required: >=0.1.5,<2.0, installed: 0.1.5]
    - six [required: >=1.4.1, installed: 1.10.0]
[...]

We don't have django-autoslug in our requirements.txt:
https://github.com/FreedomCoop/valuenetwork/blob/master/requirements.txt

@barseghyanartur
Copy link
Owner

@XaviP:

Confirmed. Somehow it happens after 0.10.6. Can't figure out yet what causes it. It will be fixed in the next version.

@barseghyanartur
Copy link
Owner

barseghyanartur commented May 14, 2017

@XaviP:

I have researched a little bit more. It seems to be a problem of wheel package (or me using it incorrectly).

If you install any version of django-fobi with pip using tar.gz download link (available on PyPI), it goes fine. The setup.py script detects your package versions and uses requirements that are valid for your setup.

Just tried it with files on PyPI:

django-fobi-0.11.4.tar.gz

pip install https://pypi.python.org/packages/a5/27/1784a45a8f3fd6b1f1047a822f761219b4242dbf08c2daa3b815de6632f7/django-fobi-0.11.4.tar.gz

However, in case of wheels it does seem to only use the requirements that were valid on the moment I have been submitting the package to PyPI. Thus, if I have been using the Python3 and Django 1.8, the hard-coded requirement of the whee distribution for django-autoslug goes all the way down to 1.7.1, because I have specified so it in the setup.py script.

django_fobi-0.11.4-py2.py3-none-any.whl

pip install https://pypi.python.org/packages/25/ee/a4a10899c7a221a104c01e8428699d1810da8d973bf6bb7243fbfd135de8/django_fobi-0.11.4-py2.py3-none-any.whl

I'll have to dive into the wheels docs to solve this problem properly. For now, I'll make a release using latest django (1.10). Hopefully, everybody else would be happy about it.

I'm releasing an updated version (0.11.5) shortly.

@XaviP
Copy link
Author

XaviP commented May 14, 2017

Thanks @barseghyanartur for your work,
We are not in a hurry, we've included django-autoslug==1.9.3 right after django-fobi in requirements.txt, so now it's solved for us, while waiting for the new fobi version. Thanks!

@barseghyanartur
Copy link
Owner

@XaviP:

Just released 0.11.5. I hope it will work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants