Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not getting output from events since last update #105

Closed
smcgann99 opened this issue Dec 2, 2021 · 5 comments
Closed

Not getting output from events since last update #105

smcgann99 opened this issue Dec 2, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@smcgann99
Copy link

Bart,

Since last update none of my clickable icons are working. There is no output from svg node when they are clicked....

@bartbutenaers
Copy link
Owner

@smcgann99,
Can you please provide a simple example flow? I have executed lots of tests for similar issues recently, but I got ZERO response on that. And on my call for beta testers, I got exactly the same amount of feedback...
Bart

@bartbutenaers
Copy link
Owner

@smcgann99,
This is caused by this error:

image

What happened:

  1. In the last release (2.3.0) the hardcoded CSS has been replaced by customizable CSS (in the new tabsheet).
  2. There was a bug in that code, so the Panzoom (and Hammer) scripts were loaded inside the CSS style tags.
  3. Since that failed, the $scope.init failed.
  4. As a result the next code was not being executed anymore, i.e. the event handlers were not applied anymore to your SVG shapes.

I have fixed this now on Github. Could you please install the version from Github (from within your .node-red folder):

npm install bartbutenaers/node-red-contrib-ui-svg

Could you please do some extra tests, and let me know if there are any other things not working anymore in your dashboard?

Thanks!!
Bart

@bartbutenaers bartbutenaers self-assigned this Dec 3, 2021
@bartbutenaers bartbutenaers added the bug Something isn't working label Dec 3, 2021
@smcgann99
Copy link
Author

It looks like thats fixed it Bart.

Many Thanks!

@bartbutenaers
Copy link
Owner

Hi @smcgann99,
Thanks for the feedback! Glad to hear that it is solved.
I will close this issue as soon as the new version is published on npm, to avoid that other users start posting duplicate issues...
Would like to solve the issue with the dashboard colors first, before I create a new version.
Bart

@bartbutenaers
Copy link
Owner

The fix has been published as version 2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants