-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to inject full svg source? #73
Comments
Hi Patrick,
Although I can see some useful use cases, I 'think' it might result in quite some redesign. But I haven't looked at this yet in detail... |
I have created a new branch "set-entire-svg-via-msg" that implements this feature.
The new feature is explained on the readme page. It would be nice if you could test this new feature (incl. event handlers, databinding, ...) before I publish it on NPM, because I'm rather short on free time to test it all by myself at the moment ... |
Thanks for immediate response. I cannot add the branch to npm:
Is this branch a private branch? Please make it public. |
No it is all public. Not sure why it fails... I assume you have git installed?? |
Yes, i have git installed. I already made a ssh key, checked it, also created a new one and replaced it in github settings but I still get an error.
|
Damn, I forgot "-ui-" in the node name. Apologies!
Hopefully it works now... |
Now I get the following error message:
|
Finally at my home computer, after a heavy day at work...
|
Yes, it works now. |
Hey Bart,
|
Hey Patrick, No problem. Thanks for testing this feature! About your add_event problem. When something doesn't work in the SVG node, you should always have a look in the browser's console log, or by activating this checkbox (e.g. for Android devices where it is hard to look in the browser log): Then you will see this error, as soon as you inject your message: And when you google about that you will find this: Your html element ID's start with a number, which is not allowed by the html standard... Please close this issue when everything is solved, so I know whether I can publish the new version on NPM. Good luck with your final exams!!! Bart |
I feel a bit stupid right now. I totaly forgot about that part with the IDs and did not notice it because it worked with the "update_style" command.. Thank you very much. One more thing i noticed today:
When using the same "add_element" Code in the master branch, everything works and i get no errors |
Nice catch! You found a bug that has been introduced by implementing the full svg source inject feature. |
Nice! |
How to inject a full svg source e.g.
using the inject node from NodeRED.
How to specify the injected msg.payload?
I could not find anything in the docs about that.
The text was updated successfully, but these errors were encountered: