Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to circle ci #182

Closed
bartdag opened this issue Dec 24, 2015 · 3 comments
Closed

Move to circle ci #182

bartdag opened this issue Dec 24, 2015 · 3 comments
Assignees
Milestone

Comments

@bartdag
Copy link
Collaborator

bartdag commented Dec 24, 2015

Travis is far from reliable and circle-ci proved to be extremely stable for our code at @resulto-admin .

@bartdag bartdag self-assigned this Dec 24, 2015
@bartdag bartdag added this to the 0.9.1 milestone Dec 24, 2015
bartdag added a commit that referenced this issue Dec 28, 2015
bartdag added a commit that referenced this issue Dec 28, 2015
bartdag added a commit that referenced this issue Dec 28, 2015
bartdag added a commit that referenced this issue Dec 28, 2015
bartdag added a commit that referenced this issue Dec 28, 2015
bartdag added a commit that referenced this issue Dec 29, 2015
bartdag added a commit that referenced this issue Dec 29, 2015
bartdag added a commit that referenced this issue Dec 30, 2015
bartdag added a commit that referenced this issue Dec 30, 2015
bartdag added a commit that referenced this issue Dec 30, 2015
@bartdag
Copy link
Collaborator Author

bartdag commented Jan 1, 2016

@243826 tests on circle ci should now run (more) smoothly.

@bartdag bartdag closed this as completed Jan 1, 2016
bartdag added a commit that referenced this issue Jan 1, 2016
@243826
Copy link
Contributor

243826 commented Jan 5, 2016

Great! Thank you!! I see that the build has passed. I'll have to submit another pull request now to see that it works consistently ;-)

Do you have anything that I can contribute on?

@bartdag
Copy link
Collaborator Author

bartdag commented Jan 5, 2016

About the build: yes, it should give reliable results now! I hadn't realised before you told me that Travis-CI configuration was the main issue. I moved Py4J to Circle-CI, which also has the advantage of including all the versions of the various compilers and interpreters in each container.

About the issues to contribute to, here are three of them that require different level of expertise. Before writing the code, though, it might be better to post on the issue your implementation plans. Do not hesitate to ask clarification questions too:

#163 has I believe the most straightforward resolution (necessary for vertx open source project)

#172 would be useful to many folks but may have performance impact so it should be configurable. There is some research to conduct on the best strategy to assign unique IDs, ideally with some micro-benchmark to assess the performance impact.

#165 is actually a symptom of the lack of proper java build configuration. Ideally, I would like to move py4j to Gradle with a maven wrapper (to be able to release Py4J to sonatype central maven repository), default configuration for eclipse and intellij, and some default checks configured. This looks promising: https://github.com/palantir/gradle-baseline

Thanks a lot for your help!

bartdag added a commit that referenced this issue May 27, 2016
bartdag added a commit that referenced this issue May 27, 2016
bartdag added a commit that referenced this issue May 27, 2016
bartdag added a commit that referenced this issue May 27, 2016
bartdag added a commit that referenced this issue May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants