Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proguard issue #480

Closed
Jiten-Medic opened this issue Dec 20, 2017 · 7 comments
Closed

Proguard issue #480

Jiten-Medic opened this issue Dec 20, 2017 · 7 comments

Comments

@Jiten-Medic
Copy link

Jiten-Medic commented Dec 20, 2017

Hi

In release build with proguard active for our project, the PDFViewer fails to open the PDF files everytime trying to open the PDF file. Where as in dev builds it's opening the files.

Please look over the issue.

Thanks

@Jiten-Medic
Copy link
Author

Please find the log on release build :

E/art: No implementation found for long com.shockwave.pdfium.c.a(int, java.lang.String) (tried Java_com_shockwave_pdfium_c_a and Java_com_shockwave_pdfium_c_a__ILjava_lang_String_2)

@Jiten-Medic
Copy link
Author

Add following to the proguard which resolves my issue :

-keep class com.shockwave.**
-keepclassmembers class com.shockwave.** { *; }

@barteksc
Copy link
Collaborator

Thanks, I will add this info to README.
Isn't only first rule sufficient?

@Jiten-Medic
Copy link
Author

I think ProGuard removes annotated EventBus subscriber methods and so events are fired but not consumed.
This rule fixes this issue.

@foxcode7
Copy link

foxcode7 commented Jan 4, 2018

thanks,very useful!

@jackgu1988
Copy link

Add following to the proguard which resolves my issue :

-keep class com.shockwave.**
-keepclassmembers class com.shockwave.** { *; }

Without the second rule I get an error while trying to access com.shockwave.pdfium.PdfPasswordException.

I think that it should be added to the README.

@decafmateen
Copy link

where we have to add that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants