Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify locations #78

Open
bartfeenstra opened this issue Jul 13, 2018 · 0 comments
Open

Simplify locations #78

bartfeenstra opened this issue Jul 13, 2018 · 0 comments

Comments

@bartfeenstra
Copy link
Owner

bartfeenstra commented Jul 13, 2018

Can we simplify locations by requiring paths to be absolute? Then we can convert all other paths, if they are relative, to absolute ones in relation to these location paths.

A use case is adding file patterns (for rsync's --exclude= and --include=). rsync does not seem to resolve those against the source path if the patterns are relative.

The implementation would involve moving the paths from locations to the top-level configuration. We can simplify the configuration files' source and target settings by repurposing those to just take strings paths. A newly introduced source_type and target_type would default to path, and a newly introduced source_configuration and target_configuration would contain any optional location configuration.

For local path locations, the source and target values may be relative. They will be provided in absolute form by resolving them against the location of the configuration file being used.

HOWEVER, this all depends on the source and target paths not changing. I don't foresee any problems within the scope of the use cases envisioned for Backuppy, but it's something to keep in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant