Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix Reanimated/GL color picker, update RNGH #8

Open
barthap opened this issue May 6, 2022 · 3 comments
Open

[Android] Fix Reanimated/GL color picker, update RNGH #8

barthap opened this issue May 6, 2022 · 3 comments

Comments

@barthap
Copy link
Owner

barthap commented May 6, 2022

  • The picker is not working on Android
  • The react-native-gesture-handler displays a warning about using the old API. Need to migrate it to use the new one
@nicredshaw
Copy link

Hi,

I've fixed this on Android (not tested on iPhone since don't have one to hand) by using the new Gesture and GestureDetector from RNGH2. I've also got rid of the annoying '-1 is not a valid color or brush' warning by providing a default value for the animated Path fill.

Note that the colour wheel still disappears when navigating away from the RGBControlScreen - I can't figure out why ?!

I would attach the files here, but Github doesn't seem to like TSX files attached to issues - can I send them to you ?

Nic

@barthap
Copy link
Owner Author

barthap commented Dec 28, 2022

You can put them in gist.github.com and send link here. Or better, you can open a Pull Request to this repository with changes to these files.

@nicredshaw
Copy link

nicredshaw commented Dec 29, 2022

Pull request added: https://github.com/barthap/expo-mega-demo/pull/11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants