Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add number of ratings #9

Closed
iljapanic opened this issue Nov 16, 2021 · 2 comments
Closed

Feature request: Add number of ratings #9

iljapanic opened this issue Nov 16, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@iljapanic
Copy link

Thanks for a wonderful library. I've just used it to successfully deploy a super simple API endpoint on Heroku to use with my personal movie database.

I was wondering if would consider also adding information about the number of ratings?

The API already returns the calculated percentage, but the number of ratings helps you better determine the relevance/significance of the rating.

I looked through your code and considered making a pull request. Unfortunately, I can't write tests and I don't think my code would be up to your standards. Hopefully, it should be quite simple to scrape the information.

Here is the element in question:

<span class="counter">**{NUMBER OF RATINGS}**</span>

CleanShot 2021-11-16 at 19 27 44@2x

@bartholomej bartholomej self-assigned this Nov 16, 2021
@bartholomej bartholomej added the enhancement New feature or request label Nov 16, 2021
@bartholomej
Copy link
Owner

bartholomej commented Nov 17, 2021

Hi Ilja, thanks for the suggestion.
You are right, this property is interesting and was missing here.

So the new version v1.8.0 already includes ratingCount

Let me know how it works ;)

If you're interested in how it's done, you can look at the pull request ;) #10

@iljapanic
Copy link
Author

Wow, that was super fast. I've just deployed the updated version to Heroku and it works great. Thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants