Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the options object optional when using actions like use:scrolltotop #1

Open
MarcusSarnes opened this issue Jan 31, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@MarcusSarnes
Copy link

Hi!

Just started using this library and its great and easy to use, however i would love if at least the scrolltotop and scrolltobottom actions options would be optional, since for my use case i don't need any extra options, but i still have to pass an empty object to satisfy the required options object, which looks kinda messy in the code template.

So more of a nice to have thing, but i feel like it makes sense to have them be optional in the case of scrolltotop and scrolltobottom, which technically don't need any extra target or options to function properly.

@bartholomej bartholomej added the bug Something isn't working label Mar 5, 2023
@bartholomej
Copy link
Owner

Hi @MarcusSarnes Let's try this version and let me know ;)

"svelte-scrollto-element": "0.8.0-next.2",

@Serator
Copy link

Serator commented May 20, 2023

Hey @bartholomej. I encountered a similar problem. In version 0.8.0-next.2 use:scrolltobottom without options does not work at all. :( I get the following error:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants