Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release with oars #30

Closed
cpba opened this issue Jun 13, 2020 · 4 comments
Closed

Create release with oars #30

cpba opened this issue Jun 13, 2020 · 4 comments

Comments

@cpba
Copy link

cpba commented Jun 13, 2020

4.0.9 fails to build on flathub because the appstream validation has been made stricter and now requires oars.

This was added to GetIt back in april #25.

However, no new releases have been made since then, so flathub can't build the last stable release.

As this is quite a small change with very little chance of causing harm, would you be open to making a new point release that included it?

Alternatively, if you think that would be better for you, the flatpak manifest could be changed to point to latest git master instead.

@bartkessels
Copy link
Owner

Hi,

Sorry for the late responses (if I've given any) but I've been very busy with school work lately. But I've created a new release for GetIt (2d7eadb).

Hopefully this will work, I'll keep this issue open until it works and the flatpack package builds.

I've been working on other projects as well so in the future the releases for GetIt on Flathub can be automated.

Kind regards

@cpba
Copy link
Author

cpba commented Jun 15, 2020

@bartkessels sorry to bother you again, I know this is a silly thing, but this introduced a new problem.

The content rating tag had already been introduced in 8bd642c, now 2d7eadb adds it again.

This means that now there's two, one at line 11:

<content_rating type="oars-1.1" />

And another one at line 72:

<content_rating type="oars-1.1" />

So appstream validation on 4.0.10 still fails, but because of too many tags, it's a bit funny when you think about it.

There's no rush. I realise you are very busy, we all are and this is of very little importance, just do it when you have time.

@bartkessels
Copy link
Owner

@cpba I thought that I've seen that tag in of or your PR's, but didn't realise it.

Anyways, there's a new commit which removes the second tag (b81c006).
The release 4.0.10 is also re-created

@cpba
Copy link
Author

cpba commented Jun 18, 2020

@bartkessels thank you, it builds perfectly now. I'll close this issue, flathub/net.bartkessels.getit#4 is ready to merge whenever you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants