Tied biases for convnets #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're going to need to rebase this against |
harm-devries
force-pushed
the
tied_biases
branch
from
8d82502
to
1e12e86
Compare
|
LGTM. It'd be nice to have a test to |
|
Agreed re: test. |
dwf
force-pushed
the
master
branch
2 times, most recently
from
461d845
to
1bb236a
Compare
|
@harmdevries89 Any chance you could finish this up by writing a short test? |
|
Yes, I will do it this week. |
|
LGTM, I'll merge when Travis passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented tied biases for convnets (default is still untied biases, though). I also added the possibility to specify
border_mode,tied_biasesfor aConvolutionalSequence.