Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear __init__.py #608

Merged
merged 3 commits into from
May 1, 2015
Merged

Clear __init__.py #608

merged 3 commits into from
May 1, 2015

Conversation

bartvm
Copy link
Member

@bartvm bartvm commented Apr 30, 2015

In order to make https://github.com/mila-udem/blocks-extras work as a namespace package, the __init__.py file needs to be entirely cleared (see https://pythonhosted.org/setuptools/setuptools.html#namespace-packages).

To make this work:

  • Set __version__ in __init__.py instead of loading it with pkg_resources
  • Move blocks.config to blocks.config.config. Not as clean, but there's not other way I can think of without programmatically changing the namespace, and I find that a bit too messy.

@rizar
Copy link
Contributor

rizar commented May 1, 2015

LGTM

@dwf
Copy link
Contributor

dwf commented May 1, 2015

Can I ask that you put some scary comments in __init__.py to discourage people from submitting pull requests that modify it?

bartvm added a commit that referenced this pull request May 1, 2015
@bartvm bartvm merged commit 5ebbf02 into master May 1, 2015
@bartvm bartvm deleted the namespace branch May 16, 2015 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants