Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default shape when initializing #8

Merged
merged 3 commits into from
Oct 15, 2014
Merged

Default shape when initializing #8

merged 3 commits into from
Oct 15, 2014

Conversation

rizar
Copy link
Contributor

@rizar rizar commented Oct 15, 2014

No description provided.

@rizar
If shape is None, use the variable's shape
5643901 
As we now allocate with the right size do not need
to provide it one more time at the initialization stage.
@rizar
Specify the shape only at the allocation stage
179eaed
@bartvm
Copy link
Member

bartvm commented Oct 15, 2014

You should probably use get_value(borrow=True, return_internal_type=True).shape, else it will copy the entire array of zeros (potentially from the GPU) just to get the shape.

bartvm added a commit that referenced this pull request Oct 15, 2014
@bartvm
Merge pull request #8 from rizar/defshape
96f0059 
Default shape when initializing
@bartvm bartvm merged commit 96f0059 into mila-iqia:master Oct 15, 2014
@rizar rizar deleted the defshape branch February 23, 2015 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rizar @bartvm