Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Add capability to translate recipes title in overview #16

Closed
NathanBnm opened this issue Mar 9, 2019 · 12 comments
Closed

Add capability to translate recipes title in overview #16

NathanBnm opened this issue Mar 9, 2019 · 12 comments

Comments

@NathanBnm
Copy link
Contributor

This is actually impossible with the recipes.json file configuration.

@unbelievableflavour
Copy link
Owner

unbelievableflavour commented Mar 11, 2019

I noticed. Any proposition on how I could achieve this? I though of maybe changing the recipes.json file like this:

{
        "id": "figs_with_goat_cheese",
        "title": {
           "en": "Figs with goat cheese",
           "nl": "Vijgen met geiten kaas",
        },
        "thumbnail": "https://static.ah.nl/static/recepten/img_011299_890x594_JPG.jpg",
        "author": "Charlotte Brussee",
        "languages": ["en", "fr", "nl"]
    },

@NathanBnm
Copy link
Contributor Author

Yes I don't know how to do that in a different way, maybe it's a good idea 👍

@unbelievableflavour
Copy link
Owner

I created a new-recipes.json for now. Will change that back to recipe.json in a week or so so that most people are migrated. It's in master and should be released soon.

@NathanBnm
Copy link
Contributor Author

Okay! Tell me if you want me to translate it before a new update 😄

@unbelievableflavour
Copy link
Owner

I picked your translations from the image descriptions :)

@NathanBnm
Copy link
Contributor Author

That's should be good so

@unbelievableflavour
Copy link
Owner

unbelievableflavour commented Mar 13, 2019

@NathanBnm I did add some lines to https://github.com/bartzaalberg/recipes/blob/master/recipes/your_own_recipe/recipe_en.md that english translation is necessary as fallback. Maybe you could add that to recipe_fr too?

@unbelievableflavour
Copy link
Owner

It's been released.
Closing this. Please reopen if not working.

@NathanBnm
Copy link
Contributor Author

Actually the recipes title translations aren't working. But everything else is good 👍

Here is a screenshot:
image

@unbelievableflavour
Copy link
Owner

Ok, so now you always get Dutch translations.. Thats not good. Will look at that tonight.

@unbelievableflavour
Copy link
Owner

Bug fix is in master. Accidentaly hardcoded NL

@NathanBnm
Copy link
Contributor Author

Okay great

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants