Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema.json for deploy.yml for auto completion #63

Closed
imWildCat opened this issue Mar 1, 2023 · 5 comments
Closed

schema.json for deploy.yml for auto completion #63

imWildCat opened this issue Mar 1, 2023 · 5 comments

Comments

@imWildCat
Copy link

Hello!

Do we open to this idea to define a JSON schema (https://json-schema.org) for deploy.yml?

With this schema, we can write deploy.yml faster.

Related tutorial: https://dev.to/brpaz/how-to-create-your-own-auto-completion-for-json-and-yaml-files-on-vs-code-with-the-help-of-json-schema-k1i

@dhh
Copy link
Member

dhh commented Mar 1, 2023

Very open. See #37.

@imWildCat
Copy link
Author

imWildCat commented Mar 1, 2023

Thank you!
My apologies! Didn't notice it. Shall we close this issue?

@dhh
Copy link
Member

dhh commented Mar 1, 2023

Yeah, I'll close. But do help out getting the other PR to the finish line, if you like.

@dhh dhh closed this as completed Mar 1, 2023
@kjellberg
Copy link
Contributor

It's pretty much ready and the validation is working, but we need to add all available configuration options and combinations. I'm not sure if they're considered "stable" yet? @dhh, the configs/fixtures at test/fixtures/*.yml, do they cover all possible configurations?

I can give you write access to my patch if you'd like to help building the schema, @imWildCat. Here's the current version: https://github.com/kjellberg/mrsk/blob/dfa8ac899782678b808ea50d2e7e91256360db58/lib/mrsk/configuration/schema.yaml

@dhh
Copy link
Member

dhh commented Mar 2, 2023

I think things are stable enough 'ish that we can complete the schema in its current form. But yeah, we'll probably have a few more changes on the path to v1.0. I'm pretty sure we've exercised all the options possible in the test cases. If not, we surely should 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants