update async component docs with feedback from RUG-N 17.06.2019 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasjabari
requested changes
Jun 18, 2019
docs/components/async.md
Outdated
| end | ||
| ``` | ||
|
|
||
| Firstly, the async component gets displayed on initial pageload, showing the most recently added user's name. On every occurance of `my_event`, the `prepare` method gets called, again fetching the most recently added user from the DB. This could lead to 1) unwanted information on the UI adn 2) a lot of unnecessary DB queries. We recommend to keep a close eye on the async component and, for this example, calling a partial with the DB query within the `div id: 'my-div'`. |
There was a problem hiding this comment.
-
You dramatize this behaviour. Rerendering is supposed to fetch the latest state from the server... I don't know how this could lead to unintentionally showing unwanted information on the UI.
-
We have to clarify the timing of DB queries according to their position on the UI. I think, currently they are always executed, even if they are exclusively defined in a block, which is not rerendered for example. I will take care of this when implementing caching
There was a problem hiding this comment.
I hope it gets clearer with the update I just pushed :)
jonasjabari
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the behaviour of the
async componentand the correspondingpreparemethod more explicit in the docs