Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share experiments data #7

Merged
merged 9 commits into from Jun 16, 2022
Merged

Share experiments data #7

merged 9 commits into from Jun 16, 2022

Conversation

ignmandagaran
Copy link
Member

@ignmandagaran ignmandagaran commented Jun 15, 2022

This PR adds a json on the public folder to share experiment data (filename, title, link, tags, number, and contributors) to use in the basement.studio/lab page

@vercel
Copy link

vercel bot commented Jun 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
experiments ✅ Ready (Inspect) Visit Preview Jun 15, 2022 at 10:05PM (UTC)

This reverts commit 124964b.
@julianbenegas
Copy link
Contributor

cuando mando un request me tira error 500

@ignmandagaran
Copy link
Member Author

cuando mando un request me tira error 500

si, estoy tratando de entender que falta porque en local funciona

@julianbenegas
Copy link
Contributor

ya sé, creo que no podes acceder al file system desde un lambda 😞

@julianbenegas
Copy link
Contributor

@ignmandagaran lo que se me ocurre es que esta función corra at BUILD TIME, y guarde un json con la data en /public/experiments.json.

y para fetchear simplemente haces fetch("https://lab.basement.studio/experiments.json")

@ignmandagaran ignmandagaran changed the title Experiments API Share experiments data Jun 15, 2022
Copy link
Contributor

@julianbenegas julianbenegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ignmandagaran ignmandagaran merged commit 337ecdb into main Jun 16, 2022
@ignmandagaran ignmandagaran deleted the nacho/experiments-api branch June 16, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants