Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows版SQLiteの対応バージョンをconfig化する #1430

Closed
yama opened this issue Apr 23, 2020 · 1 comment
Closed

Windows版SQLiteの対応バージョンをconfig化する #1430

yama opened this issue Apr 23, 2020 · 1 comment
Labels
Todo 実行確定タスク
Milestone
4.3.5

Comments

@yama
Copy link
Contributor

yama commented Apr 23, 2020

概要

#1427
上記マージ対応、ありがとうございました。細かい話ですみませんが、利用を許可するSQLiteのバージョンはコード内に直書きせずにconfigにまとめたほうがよいかと思いました。

Configure::read('BcRequire.winSQLiteVersion');

もしよければ追加でプルリクを作成いたします。

baserCMS version : 4.3.x
@ryuring
Copy link
Collaborator

ryuring commented Apr 23, 2020

@yama 確かにそうですね。まとめお願いします！

@ryuring ryuring added the Todo 実行確定タスク label Apr 24, 2020
@ryuring ryuring added this to the 4.3.5 milestone Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Todo 実行確定タスク
Projects
None yet
Milestone
4.3.5
Development

No branches or pull requests
2 participants
@yama @ryuring