Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem completion and slow loading #73

Closed
vcastellm opened this issue Jul 24, 2011 · 15 comments
Closed

Gem completion and slow loading #73

vcastellm opened this issue Jul 24, 2011 · 15 comments

Comments

@vcastellm
Copy link
Contributor

Gem completion script makes each new terminal window take ages to load. Just deleting the symlink from enabled completions folder makes it load reasonable well.

@ghost
Copy link

ghost commented Jul 24, 2011

Unfortunately it's not possible to make it any faster since bash_it needs to get a list of gems each time it loads the completion.

On Jul 24, 2011, at 11:48 AM, victorcoder wrote:

Gem completion script makes each new terminal window take ages to load. Just deleting the symlink from enabled completions folder makes it load reasonable well.

Reply to this email directly or view it on GitHub:
#73

@vcastellm
Copy link
Contributor Author

Yes and I think it's preferably to not enable it by default because it can create a bad impression for new users.

@ghost
Copy link

ghost commented Jul 24, 2011

I can't stop from enabling it by default. We automatically enable all completion plugins by default.

@tswicegood
Copy link
Member

It might be worthwhile to add an exemption and/or allow the users to decide which ones they want to enable on tha first pass thru.

@ghost
Copy link

ghost commented Jul 24, 2011

I might add something to the install script. Anyone else think this is a good idea? I was planning on adding something like this:

tell the user:

bash_it comes with tab-completion for the gem command. Using this requires it to download a list of gems which will make shell startup time slower. Would you like to enable this completion plugin? (Y/N)

@tswicegood
Copy link
Member

I think it could be even simpler (from the user's perspective, not ours):

Would you like to enable all, some, or none of the [plugins|completion|aliases] (this may make bash_it run slower):
[All/Some/None]:

All continues to act as it currently does, Some prompts the user for each one, None skips the step all together.

@vcastellm
Copy link
Contributor Author

Could be possible to make it like in omz? load just the list of commands and load gems list on demand

@ghost
Copy link

ghost commented Jul 24, 2011

@tswicegood's idea looks like a good one. I'll try implementing it.

@ghost ghost self-assigned this Jul 24, 2011
@ghost
Copy link

ghost commented Jul 24, 2011

Fixed with 021000c.

@ghost ghost closed this as completed Jul 24, 2011
@vcastellm
Copy link
Contributor Author

It's an old commit, push pending?

@ghost
Copy link

ghost commented Jul 24, 2011

Oh, sorry. Typo. Was fixed in 3eff6b2.

@vcastellm
Copy link
Contributor Author

Oh, I think you were going to fix the gem completion file.

Selecting "some" drives through an endless process that I thinks it's not that great idea.

I'll try to help with this.

@tswicegood
Copy link
Member

@mr-szymanski I was thinking more along the lines of moving the for loop into the while true loop so you would be asked for each type so you could enable all plugins, some aliases, and none of the completion, or so on.

@ghost
Copy link

ghost commented Jul 24, 2011

Ahh, ok. I'll try that, then. Thanks.

@ghost
Copy link

ghost commented Jul 24, 2011

Fixed with 159e1e4.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants