Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to BrowserSync is broken #1

Open
micahlisonbee opened this issue Oct 13, 2014 · 5 comments
Open

Reference to BrowserSync is broken #1

micahlisonbee opened this issue Oct 13, 2014 · 5 comments

Comments

@micahlisonbee
Copy link

When creating a new browser-sync-instance I get:

Error: Cannot find module './node_modules/browser-sync/package.json' at Function.Module._resolveFilename (module.js:338:15) at Function.Module._load (module.js:280:25) at Module.require (module.js:364:17) at require (module.js:380:17) at Object. (/Code/Boncom/boncom-labs-icarus/node_modules/browser-sync-instance/index.js:8:21) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12) at Module.require (module.js:364:17)

The issue is resolved by changing the refs to "../../node_modules/browser-sync/..." Not sure if that's a good fix though...

@basham
Copy link
Owner

basham commented Oct 14, 2014

Thanks for posting the issue. When I used npm link when developing the module, it all worked as intended. However, I failed to test it as a true npm dependency, and I'm noticing similar module reference problems. Will investigate.

@micahlisonbee
Copy link
Author

Cool, thanks for looking in to it.

@basham
Copy link
Owner

basham commented Jan 21, 2015

@micahlisonbee Sorry for putting no work into this issue to date. However, it seems as if this project did what it was intending, inspiring this feature to be included officially in BrowserSync. You can follow its progress on the multi-instance branch. Therefore, I don't see much point investing further time in this project, even to fix this critical bug. That is, unless you have a particular need that the multi-instance branch doesn't solve for you.

@shakyShane
Copy link

@basham thanks for updating - just one note though, anyone wanting to check out the new functionality should actually use the develop branch as this is much further ahead & is what will ultimately land in master.

https://github.com/shakyShane/browser-sync/tree/develop

:)

@basham
Copy link
Owner

basham commented Jan 21, 2015

@shakyShane Excellent. Thanks for the correction. The depreciation notice on the README now correctly links to the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants