New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterator API #65
Iterator API #65
Conversation
I don't see a reason not to do this. Opinions @gburd or @justinsheehy or @jonmeredith? |
@slfritchie agreed, +1 to merge |
If necessary, I can also add iterator, iterator_next and iterator_release wrappers in |
(since bc_state is effectively opaque) |
Yurii, the extractors sound good, er, or even necessary. I guess it becomes the user's responsibility to not do anything dumb with that state. You could (in theory) go meddling with the keydir and break things in countless ways. But if that's what you want to do, that's rope that I'm willing to give. Any disagreement, oh Bashonians? |
I am working on wrappers already. |
I'd personally like to see the wrappers. Bitcask should present a single-module interface rather than have people digging in the process dictionary and working out the NIF arguments. (just saw you say you were working on wrappers as I wrote it). |
Added wrappers |
Thoughts? Can we merge this? I would love to be able to use this instead of playing with an opaque structure stored in my process' dictionary... |
+1 Merging. |
This change allows applications that need something more controllable than a "blind fold" to iterate over bitcask keydir keys.