Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move element creation to outside the pool mutex #8

Closed
wants to merge 4 commits into from
Closed

Move element creation to outside the pool mutex #8

wants to merge 4 commits into from

Conversation

corasaurus-hex
Copy link

Fixes #1. Moved element creation to outside the pool mutex.

seancribbs
seancribbs reviewed Jan 22, 2015
View reviewed changes
lib/innertube.rb
element.lock
@pool << element
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think you should take the lock when appending an element to the pool.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good call.

@corasaurus-hex
Copy link
Author

Not a clue what's going on with rbx-2.5.0. I can't get it to install on my machine.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove element creation from inside the mutex on the pool
2 participants
@corasaurus-hex @seancribbs