Repair updated for edge case created with new directory structure. #78
Conversation
ghost
assigned …ore complex code to address correctly.
|
|
||
| db_ptr=NULL; | ||
| options=org_options_; | ||
| options.block_cache=options_.block_cache; |
There was a problem hiding this comment.
Is there any danger in reusing this block cache for the level repair operation here? I haven't fully grasped what the code before this may put in it or where the repair may pull data out of it, but I was wondering if it was safer to just use a fresh one here.
There was a problem hiding this comment.
The block cache is global to the database (vnode). It's pointer has to be passed around different operations simply to give access. That is what you are seeing here. Good question though.
|
After talking to @matthewvon about this we have agreed to avoid block cache reuse here to avoid any potential current or future weirdness if semantics change. In this case, it is only reused within the repair operation. When used from eleveldb, it is not sharing an existing block cache anyway (so not shared with the Riak vnode). So I'm giving this a 👍 💃 ⛵ conditional on the code changing to create a new block cache (options block_cache set to NULL). It will be taken away if any other naughtiness is introduced, however :) |
…, but there could be edge cases not seen or future code that would break assumptions.
Repair updated for edge case created with new directory structure.
See discussion here: https://github.com/basho/leveldb/wiki/mv-repair-by-level