Setting bucket properties is goofy

[bkerley]

Developers want to do this:

bucket.props['precommit'].push({ 'mod' => 'validate_json', 'fun' => 'validate' })

What happens is this fetches the props hash from Riak, and then mutates that has in place. At no time is it saved to Riak.

Doing this should save it:

bucket.props['precommit'].push({ :mod => 'validate_json', :fun => 'validate' })
bucket.props = {}

But it's terribly unintuitive.

[bkerley]

    it 'works like a hash' do
      expect(props['r']).to eq 'quorum'
      expect{ props['r'] = 1 }.to_not raise_error
      expect{  props.store }.to_not raise_error
      props.reload
      expect(props['r']).to eq 1
    end

    it 'works like with accessor methods' do
      expect(props.r).to eq 'quorum'
      expect{ props.r = 1 }.to_not raise_error
      expect{ props.store }.to_not raise_error
      props.reload
      expect(props.r).to eq 1
    end

[bkerley]

TODO: test it with composite/hash properties like the modfun above.

[lukebakken]

Ruby-n00b question: why set e when it's unused?

[bkerley]

I so the exception goes into a variable and I can find it in a debugger. I should probably roll that one back.

[lukebakken]

Thanks for the explanation.

[lukebakken]

@bkerley this all looks great and is very easy to follow.

[drewkerrigan]

+1 3257730

[bkerley]

@borshop merge