SSL support #291
Merged
SSL support #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| MySSL = proplists:get_value(ssl_enabled, TheirCaps, false), | ||
| TheirSSL = proplists:get_value(ssl_enabled, MyCaps, false), | ||
| case {MySSL, TheirSSL} of | ||
| {true, false} -> lager:info("FAILED TO USE SSL A"), |
There was a problem hiding this comment.
These lager:info weren't really meant to make it into a PR as they were.
There was a problem hiding this comment.
Yes, I forgot to do a cleanup commit.
|
There are several lager:info/lager:error calls that I was using during dev. These need to be cleaned up. |
ghost
assigned | lager:info("Peer requested SSL but we don't support it"), | ||
| {error, no_ssl}; | ||
| {true, true} -> | ||
| lager:info("Agreed to use SSL"), |
There was a problem hiding this comment.
It would be nice if the info could read: Agreed to use SSL from foo to bar. (source/sink)
|
replication2_ssl + replication2 tests pass. |
|
How does this look? |
|
output looks good: replication2 + replication2_ssl pass again. |
This is a port of the SSL implementation from Riak's MDC implementation. The app.config arguments are the same, only now they're under riak_core. SSL is negotiated right after capabilities are exchanged, so minimal information is sent 'in the clear'. If one side requests SSL and the other side does not have it enabled, SSL is not allowed to connect.
buddhisthead
added a commit
that referenced
this pull request
Apr 21, 2013
Add the riak_kv_yessir_backend.erl storage manager for simulation purposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.