Fix crashing stat mod never getting rescheduled #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.3.1 updated the cache to fetch stats in the background rather than on demand. A new bug was added. If the stat mod crashes during production of stats, it is never rescheduled. Fix by rescheduling when crash is detected. Exponentially backoff the schedule after an error so as not to spam the log.
|
Fixes #335 |
|
is this the master version of #338? |
|
Also 👍, sorry I didn't review it at the same time. |
russelldb
added a commit
that referenced
this pull request
Jun 21, 2013
Fix crashing stat mod never getting rescheduled
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #335
1.3.1 updated the cache to fetch stats in the background rather than
on demand. A new bug was added. If the stat mod crashes during
production of stats, it is never rescheduled.
Fix by rescheduling when crash is detected. Exponentially backoff
the schedule after an error so as not to spam the log.