Add new backend capability for Riak r_object use #552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add backend-specific bucket & key name generators and fix type spec typo
|
NOTE: Branches are apparently hard. This should be merged to master, not the base branch that GitHub is thinking of. |
ghost
assigned 
| {erl_opts, [warnings_as_errors, {parse_transform, lager_transform}]}. | ||
| {erl_opts, [warnings_as_errors, | ||
| {parse_transform, lager_transform}, | ||
| {d, 'TEST_FS2_BACKEND_IN_RIAK_KV'}]}. |
There was a problem hiding this comment.
what this define is used for?
There was a problem hiding this comment.
For testing riak_kv_fs2_backend.erl, which is in the CS repo.
|
EDIT: any reason to not re-submit this PR against master? |
slfritchie
added a commit
that referenced
this pull request
May 17, 2013
|
Closing with commit 146e3ca (the result of a merge conflict, which I fixed, EUnit tests passing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the optional riak_kv backend capability to pass Riak r_object records to/from the backend rather than binary blobs that are serialized/unserialized by
riak_kv_vnode.Also, rearrange the QuickCheck tests to permit easier testing of the fs2 backend.