Stop fold when a vnode reaches page size #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, 2i pagination may, with a sufficiently slow participating node, receive many, many more keys than the page size (max_results) from all the other participating nodes. This change will track how many results have been received per vnode, and send a stop fold message to a vnode as soon as it has sent more than max_results. Note, however, that vnodes will send in chunks possibly much larger than the page size (100 items at a time I believe). It would be ideal to pass max_results to the folding function and have it stop when it reaches that number. But that will have to wait until later. Release is near. This should at least prevent a worst case of unbounded growth that could consume all the node memory
|
Looks good to me. A sensible addition. |
engelsanchez
added a commit
that referenced
this pull request
Jun 25, 2013
Stop fold when a vnode reaches page size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, 2i pagination may, with a sufficiently slow participating
node, receive many, many more keys than the page size (max_results) from
all the other participating nodes.
This change will track how many results have been received per vnode,
and send a stop fold message to a vnode as soon as it has sent more than
max_results.
Note, however, that vnodes will send in chunks possibly much larger than
the page size (100 items at a time I believe). It would be ideal to pass
max_results to the folding function and have it stop when it reaches
that number. But that will have to wait until later. Release is near.
This should at least help prevent a worst case of unbounded growth that could
consume all the node memory simply because one node is too slow.
/cc @russelldb @jtuple @evanmcc @jrwest