Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider developing a more sophisticated INFO/WARN/ERROR system for compiler issues #677

Open
chrisrink10 opened this issue May 6, 2022 · 1 comment
Labels
compiler Issue pertaining to compiler enhancement New feature or request

Comments

@chrisrink10
Copy link
Member

Currently, info messages and warnings are simply emitted by the Basilisp compiler (analyzer) logger, which is just a standard Python logger. Errors are generally exceptions which immediately stop the compilation process.

It may be worthwhile to think about collecting those errors via the Context object, rather than having them emitted simply as text warnings. As it stands, there's no easy way to (say) configure a warning as an error and stop compilation.

Also, warnings are all added relatively ad-hoc and each have their own custom flags. It may be worth considering having a standard warning/error naming system.

@chrisrink10 chrisrink10 added enhancement New feature or request compiler Issue pertaining to compiler labels May 6, 2022
@chrisrink10 chrisrink10 added this to To do in Advanced compiler changes via automation May 6, 2022
@chrisrink10
Copy link
Member Author

Thought of while working on #671

@chrisrink10 chrisrink10 added this to the Release v0.1.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Issue pertaining to compiler enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant