Frame rate not adjusting with new ROI

[J-C-Haley]

Hello, I'm trying to use the SetROI service to reduce data load, and my expectation was that frame rate would rise to the maximum (as a function of exposure, allowed bandwidth, and set frame rate), as it does in the pylonviewer GUI. However, current behavior is to limit the frame rate on startup (here), based on the startup settings (ROI/exp/framrate), and this overrides the frame_rate ROS parameter, even if the SetROI (here) were to attempt to reset the frame rate the original parameter has been destroyed, so further dynamic changes have no rate increase effect.

So, my question is, shall we either:

• have a separate parameter to store the intended max framerate (e.g. target_frame_rate), so we preserve the user intent, or,
• not override the ros frame_rate parameter with the startup max framerate, and simply report achieved rate in the terminal or possibly another param (achieved_frame_rate)

I'd prefer the latter, it's a quick fix I can contribute, but I'd like to hear input on if this would break anything.

Thank you!

[J-C-Haley]

Ah, I see this is a bigger problem than I assumed, frame rate gets baked into the main ros::Rate spin on startup, which is not adjustable from within the pylon_camera_node. Either of these fixes would require transferring ownership of the rate into the node, so it can be adjusted...

[FrancoisPicardDTI]

Hello @J-C-Haley
I just added a section in the documentation.
There are several issues, and several solutions, to increase the frame rate.
If the camera image acquistion is triggered by sofware trigger (default setting), then it is not possible to get the maximum frame rate, because the image acquisition is sequentially triggered, which is not overlapping then.
Several possible solutions are mentionned and tested in issue #21, #28, #29, #81, #116, #147, and #200. Please refer to them for more information and hopefully find a solution for your use case.