Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accent colors at daytime #40

Open
Oekn5w opened this issue Nov 8, 2020 · 6 comments
Open

Accent colors at daytime #40

Oekn5w opened this issue Nov 8, 2020 · 6 comments

Comments

@Oekn5w
Copy link
Contributor

Oekn5w commented Nov 8, 2020

I'd like to have an accent color on my lights, so you basically choose the color when the switch would generate a white light.

I'm already working on this and I'd like to know the other's opinion on this feature (Basically whether I should PR the changes).

If you're interested, my usability concept is like this:

  • add another switch to enable / disable this
  • color can be given via yaml or service call (new service: set_accent_color), yaml overrides last_state on startup
  • yaml also configs the interpolation endpoints (based on the internal percentage)

Functionality:

  • below the lower threshold the functionality isn't affected (nighttime color temperatures)
  • above said threshold, the rgb values are interpolated between the "default" rgb and the given accent color

Opinions?

@R3yn4ld
Copy link

R3yn4ld commented Nov 24, 2020

Hi, that's a nice idea. However, it may break the circadian rythm?

However, having accent (minimum) brightness would be awsome !
Use case: while dinning I wan't a 10050% brightness curve but then, during the evening, a 1001% curve.

@RubenKelevra RubenKelevra changed the title Feature Request: Accent colors at daytime Accent colors at daytime Jul 31, 2021
@RubenKelevra RubenKelevra added this to the v2.0 milestone Jan 8, 2022
@RubenKelevra
Copy link
Collaborator

I'm currently in the process of doing version 2. This will be added/fixed.

Keep this ticket open until you can verify that it's properly working in the upcoming version 2.

@RubenKelevra RubenKelevra self-assigned this Jan 8, 2022
@RubenKelevra RubenKelevra added this to To do in v2 Jan 8, 2022
@Oekn5w
Copy link
Contributor Author

Oekn5w commented Jan 8, 2022

I've added this shortly after me opening the issue, I don't know if it's in my fork though. Let me see. I don't remember why I didn't PR it

@Oekn5w
Copy link
Contributor Author

Oekn5w commented Jan 8, 2022

Ah I didn't fork it, I've directly added the feature in my repo that keeps all of my custom stuff, I'll make a branch

@Oekn5w
Copy link
Contributor Author

Oekn5w commented Jan 8, 2022

@RubenKelevra I dunno why I didn't PR this (possibly because I didn't implement, test all the UI setup part, because I'm not using it), but here you go, upstream changes merged just now: https://github.com/Oekn5w/adaptive-lighting/tree/accent_colors

@RubenKelevra
Copy link
Collaborator

RubenKelevra commented Jan 8, 2022

Hey @Oekn5w I've merged it into a branch in this repo and I'll have a look at it.

v1 has a feature freeze due to the v2 development :)

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2
Inbox
Development

No branches or pull requests

5 participants