Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with invalid measurements reported from the sensor #48

Closed
ChristianKuehnel opened this issue Oct 18, 2017 · 1 comment
Closed

Deal with invalid measurements reported from the sensor #48

ChristianKuehnel opened this issue Oct 18, 2017 · 1 comment
Labels
enhancement Hacktoberfest help wanted

Comments

@ChristianKuehnel
Copy link
Collaborator

ChristianKuehnel commented Oct 18, 2017 •
edited

Sometimes the reading of the measurements fails and then the sensor returns INVALID_DATA = b'\xaa\xbb\xcc\xdd\xee\xff\x99\x88wf\x00\x00\x00\x00\x00\x00'.

My guess is: this happens when this operation fails: connection.write_handle("0x33", "A01F"):

We need someone to investigate the issue further and implement a solution that solves this this issue. My idea would be to retry reading the data we get the INVALID_DATA.

See also the discussion in #40
@ChristianKuehnel
Copy link
Collaborator Author

I just looked at the code and added some unit tests. This should not be a problem any more. If this is still an issue, please create a new bug report

@dingausmwald dingausmwald mentioned this issue Oct 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChristianKuehnel