Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic Google Search infinite reloading bug #23

Open
basshelal opened this issue Sep 4, 2020 · 0 comments
Open

Arabic Google Search infinite reloading bug #23

basshelal opened this issue Sep 4, 2020 · 0 comments
Assignees
Labels
Bug Something isn't working Important Something that needs immediate attention

Comments

@basshelal
Copy link
Owner

Replicate by:

  • New Incognito Window (Wudooh on!)
  • Google.com
  • Change region to Arabic region (QA for example) (do this at bottom right Settings -> Search Settings)
  • Change language to Arabic (this is important, English Google is fine)
  • Search anything
  • Watch the page reload forever

I have no idea what is causing this, highly highly likely it is on Google's end and not ours but we still need to know what is causing this.

The only solution is to whitelist or turn off Wudooh, delaying the update still breaks it.

I am curious if Google can actually detect the update function changing stuff on the page and doesn't like it and causes a refresh maybe as a security thing or something as many garbage extensions will actuall insert ads into Google search results even if you have adblock on (seen this firsthand). This is troubling but I'll need to explore further, if it really is the case then we need to change to an update by changing styling method and not update by adding Nodes or HTMLElements.

Look at #7 again because we explored the advantages and issues of such a method, mainly when a HTMLElement has both text to be updated (Arabic) and text to be ignored within it. The best looking way is the current, make a new HTMLElement for the text to be updated and set its styling but the ignored text remains the same. Thus the non-Arabic text is identical and only the Arabic text appears differently.

Absolute worst case, we make a switch for both methods with users changing methods as they wish and we ship an optimal list of them. This means adding a new element to the database. But this would technically kind of fix #7 but not in the ideal way but would also significantly complicate the extension as users now have to understand how the extension works. Inconvenient, but again what's worse is that it's all not ideal, it's just a fix but not a solution.

While I hate having to accomodate for other site's weird behaviors, in this case I don't mind as much because I know the reason Google are doing this and I completely understand it and kind of support it if I am correct.

Extension is free but now our thousands of users have to see shitty ads on their Google search results (which Google themselves have no idea about) which we'll make (probably illegal and definitely unethical) money from. Imagine how far this could go, and all from a shitty extension that downloads videos or does YouTube analytics or whatever in which case...

Fuck you you filthy capitalist human garbage dirty cunt companies who make things worse for everyone for a quick (and small) buck.

Indeed, money is the root of all evil.

@basshelal basshelal added the Bug Something isn't working label Sep 4, 2020
@basshelal basshelal self-assigned this Sep 4, 2020
@basshelal basshelal pinned this issue Sep 4, 2020
@basshelal basshelal added the Important Something that needs immediate attention label Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Important Something that needs immediate attention
Projects
None yet
Development

No branches or pull requests

1 participant