Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining a VOLUME in Dockerfile makes it impossible to use as ephemeral/stateless/self-contained image #509

Closed
patrickfav opened this issue Sep 16, 2022 · 2 comments

Comments

@patrickfav
Copy link

Hi, thanks for the great project, I think homer is the best status/dashboard for self hosted services!

To my issue: I usually try to design docker images as ephemeral/stateless/self-contained where I pack all the necessary files in the image during build time. This makes it easy to:

  • Change a file
  • Run my docker build (which copies the file to e.g. /www/assets)
  • Deploy

Done.

Since the base Dockerfile defines a VOLUME i cant do that because it always wants me to map this volume to somewhere and use that volume instead of the statically copied files. Usually the approach I know of is to NOT define "VOLUME" in dockerfile, but give the user the hint to use it in docker-compose file or docker run, haveing the best of both worlds.

So my question is if you would be open to remove the VOLUME in your Dockerfile?

@bastienwirtz
Copy link
Owner

Hello @patrickfav,

Thanks for pointing that out. The VOLUME is kind of useless as the content is static, Homer will never make any changes to it. I removed it 👍

@patrickfav
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants