Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub actions instead of Travis #43

Open
bastilimbach opened this issue Jul 5, 2020 · 3 comments · May be fixed by #45
Open

Use GitHub actions instead of Travis #43

bastilimbach opened this issue Jul 5, 2020 · 3 comments · May be fixed by #45
Assignees
@bastilimbach
Labels
enhancement help wanted

Comments

@bastilimbach
Copy link
Owner

See #25 (comment)
@bastilimbach bastilimbach self-assigned this Jul 5, 2020
@bastilimbach bastilimbach mentioned this issue Jul 5, 2020
Merged
2 tasks
@Legion2
Copy link
Contributor

Legion2 commented Jul 5, 2020

@bastilimbach What is this line for?

docker-MagicMirror/build.sh

Line 6 in 0d51263

if [ "$(docker manifest inspect bastilimbach/docker-magicmirror:"${latest_release}" > /dev/null; echo $?)" != 0 ]; then

@bastilimbach
Copy link
Owner Author

@Legion2 it checks if there is already an image with that particular tag/version on docker hub. This is to prevent overriding existing tags.

@Legion2
Copy link
Contributor

Legion2 commented Jul 5, 2020

But there should be no problem if we override a tag with a newer build of the same tag. It uses the same code base but maybe newer base images and dependencies.

@Legion2 Legion2 linked a pull request Jul 5, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bastilimbach bastilimbach

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace travis with GitHub Actions workflow Legion2/docker-MagicMirror
2 participants
@bastilimbach @Legion2