Switch from JCraft JSch to mwiede/jsch

[svengo]

It doesn't look like JSch from JCraft is still under active development, according to the changelog the last code changes are from 2018. Thus the library lacks modern features like Ed25519 keys and current cryptographic algorithms.

With mwiede/jsch there might be a fork available that can be used without any effort.

I wanted to get opinions here before starting a PR.

[webkp]

I found this issue while I was looking for a solution to use Ed25519 keys and looks like others are/were looking for a solution, too.
+1 from me.

Issues related to Ed25519:
#266 (Support for Ed25519 keys)
#223 (Add support for ed25519 keys)
#343 (Support for ed25519)

[skavanagh]

+1

[svengo]

I just did some trial and error. Maybe I was a bit quick, there are obviously a few more changes needed to switch Bastillion to a different jsch. My Java knowledge is unfortunately not sufficient for this, maybe someone else can step in :-)
Support for ed25519 keys would be really nice.

[Dando-Real-ITA]

+1

[svengo]

Could someone please check if this issue is fixed by b458937afffe71df54e8aea8b5251c419c0914e1?

[Dando-Real-ITA]

I am using 3.14.0 and ed25519 was not working with an imported key pair - it shows the public key in the logs but then I cannot connect to a server