Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Laravel 10? #20

Open
jakemarchant opened this issue May 17, 2023 · 4 comments
Open

Support for Laravel 10? #20

jakemarchant opened this issue May 17, 2023 · 4 comments

Comments

@jakemarchant
Copy link

No description provided.

@rik43
Copy link

rik43 commented Jun 22, 2023

I found several forks of this repository with corrected compatibility.
simply remove bastinald/laravel-livewire-modals
and add, for example (this is not mine)
composer require abovesky/laravel-livewire-modals
There is no need to change anything else.

Also, if you have time to rewrite the code, it makes sense to consider newer and more functional components, for example. https://github.com/wire-elements/modal

@jakemarchant
Copy link
Author

Thanks! I did have a Google when I opened the ticket but couldn't find anything useful so ended up making my own package, never thought to check the forks!

I did have a look at the Wire Elements/Modal and it looks great but I am not a fan of Tailwind - I know unpopular opinion!

@rik43
Copy link

rik43 commented Jun 23, 2023

its allow to change css framework,

The base modal is made with TailwindCSS. If you use a different CSS framework I recommend that you publish the modal template and change the markup to include the required classes for your CSS framework.

see
https://github.com/wire-elements/modal#tailwindcss

I use tailwind, but not everywhere

@jakemarchant
Copy link
Author

I'll give it a look - thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants