Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running merlon init after deleting the .merlon folder destroys the /papermario folder #25

Closed
Pronyo-Chan opened this issue Apr 29, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Pronyo-Chan
Copy link

  1. Create a new merlon package with merlon new
  2. in the new mod folder, run merlon init
  3. Delete the .merlon folder
  4. Run merlon init again

Result: The papermario folder gets deleted and the following error is printed:

fatal: destination path 'papermario' already exists and is not an empty directory.
Error: failed to initialise package test by Pronyo <franktb93@gmail.com>

Caused by:
    failed to clone decomp repository

This is a potentially destructive operation if the user had unpushed/unexported changes in the papermario folder

@bates64 bates64 added the bug Something isn't working label Apr 29, 2023
@bates64
Copy link
Owner

bates64 commented Apr 29, 2023

Some thoughts:

  1. Don't delete the directory, obviously
  2. A better error message - we could ask the user to delete papermario if and only if they know their changes are backed up
  3. Have merlon init work if there is a directory already, and just sync it & create .merlon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants