Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juniper Community Lists Matching Logic #4190

Closed
Volcanon- opened this issue Jul 3, 2019 · 2 comments · Fixed by #4885
Closed

Juniper Community Lists Matching Logic #4190

Volcanon- opened this issue Jul 3, 2019 · 2 comments · Fixed by #4885
Assignees

Comments

@Volcanon-
Copy link

Volcanon- commented Jul 3, 2019

I had a case where I had a community list like this:

community COMM1 members [ 1:2 3:4 ];

And I had a policy which matched on this and then applied additional communities. The problem I was having is that routes with just 3:4 were being matched on this. When I removed 3:4 from the list it wasn't an issue, but it seems like Batfish is performing a logical OR on these, when it should be ANDing them.

A simple test bench should be able to confirm this behavior. Let me know if you need more info.

Juniper Doc ref:
https://www.juniper.net/documentation/en_US/junos/topics/concept/policy-bgp-communities-extended-communities-evaluation-in-routing-policy-match-conditions.html

@dhalperi
Copy link
Member

dhalperi commented Oct 4, 2019

I believe @arifogel has fixed this now, but we'll confirm and get back to you @Volcanon-

@arifogel
Copy link
Member

arifogel commented Oct 4, 2019

This has already been fixed, though a test was missing.
I added an appropriate test in #4885.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants